Re: [PATCH v3 1/2] virt: vbox: Add check for device_create_file

From: Greg KH
Date: Thu Sep 01 2022 - 10:22:36 EST


On Thu, Sep 01, 2022 at 09:15:06PM +0800, Jiasheng Jiang wrote:
> As device_create_file() can return error number,
> it should be better to check the return value and
> deal with the exception.
> Moreover, this driver should be using an attribute group.
>
> Fixes: 0ba002bc4393 ("virt: Add vboxguest driver for Virtual Box Guest integration")
> Signed-off-by: Jiasheng Jiang <jiasheng@xxxxxxxxxxx>

Your subject line is now incorrect :(

Also, please properly thread your patches when you send them. I saw a
2/2 but no v3 on that. The whole series is versioned and needs to be
connected.

thanks,

greg k-h