Re: [PATCH v1 2/3] regmap: trace: Remove explicit castings

From: Andy Shevchenko
Date: Thu Sep 01 2022 - 10:18:54 EST


On Thu, Sep 1, 2022 at 5:15 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Thu, Sep 01, 2022 at 04:23:35PM +0300, Andy Shevchenko wrote:
> > There is no need to have explicit castings to the same type the
> > variables are of. Remove the explicit castings.
>
> IIRC this was an idiom that the trace code was using for some deep magic
> reason to do with some fiddly preprocessor stuff.

Perhaps that (dark) magic disappeared a long time ago since in my
practice of adding trace events this is the first (and probably
oldest) one which has these castings. Perhaps Steven can shed a light.

--
With Best Regards,
Andy Shevchenko