RE: [PATCH v1 tty-next 1/2] 8250: microchip: pci1xxxx: Add driver for the quad-uart function in the multi-function endpoint of pci1xxxx device.

[Ilpo Järvinen]

On Thu, 1 Sep 2022, Kumaravel.Thiagarajan@xxxxxxxxxxxxx wrote:

> > > +       const unsigned int standard_baud_list[] = {50, 75, 110, 134, 150, 300,
> > > +                                               600, 1200, 1800, 2000, 2400, 3600,
> > > +                                               4800, 7200, 9600, 19200, 38400, 57600,
> > > +                                               115200, 125000, 136400, 150000, 166700,
> > > +                                               187500, 214300, 250000, 300000, 375000,
> > > +                                               500000, 750000,
> > > + 1000000, 1500000};
> > 
> > Why?!
>
> The standard baud rates are handled within serial8250_do_set_termios 
> which is invoked from within mchp_pci1xxxx_set_termios in first place. 
> Hence if it matches with any of the standard baudrates,
> it can return immediately.

Care to explain why the baudrates in your table don't match those in 
tty_baudrate.c? ...It makes no sense to me that you call these "standard 
baud rates".


-- 
 i.