RE: [PATCH v2 1/2] dt-bindings: mtd: spi-nor: Add reset-gpios property

From: Potthuri, Sai Krishna
Date: Thu Sep 01 2022 - 06:18:47 EST


Hi Krzysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Thursday, September 1, 2022 1:26 PM
> To: Potthuri, Sai Krishna <sai.krishna.potthuri@xxxxxxx>; Tudor Ambarus
> <tudor.ambarus@xxxxxxxxxxxxx>; Pratyush Yadav <pratyush@xxxxxxxxxx>;
> Michael Walle <michael@xxxxxxxx>; Miquel Raynal
> <miquel.raynal@xxxxxxxxxxx>; Richard Weinberger <richard@xxxxxx>;
> Vignesh Raghavendra <vigneshr@xxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; saikrishna12468@xxxxxxxxx; git (AMD-Xilinx)
> <git@xxxxxxx>
> Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: spi-nor: Add reset-gpios
> property
>
> On 01/09/2022 10:29, Sai Krishna Potthuri wrote:
> > SPI-NOR flashes have RESET pin which can be toggled using GPIO
> > controller, for those platforms reset-gpios property can be used to
> > reset the flash device.
> >
> > Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@xxxxxxx>
> > ---
>
> You still miss the user (DTS) of this change...
Do you mean to have this property in example DTS in this yaml?

> The JEDEC spec did not mention
> a reset pin. Can you provide the user?
Xilinx Octal SPI (cdns,qspi-nor.yaml) is using this reset pin to reset the
flash device on Versal platform.
Do you want me to update the example dts in cdns,qspi-nor.yaml file
to reflect this property in this patch?

Regards
Sai Krishna