Re: [PATCH] arch/riscv: kprobes: implement optprobes

[Conor.Dooley]

On 31/08/2022 08:24, Conor Dooley - M52691 wrote:
> Hey Chen,
> 
> FYI there is a build warning with this patch:
> arch/riscv/kernel/probes/opt.c:34:27: warning: no previous prototype for 'can_kprobe_direct_exec' [-Wmissing-prototypes]
>     34 | enum probe_insn __kprobes can_kprobe_direct_exec(kprobe_opcode_t *addr)
> 
> Also, if you run scripts/checkpatch.pl --strict, it will have a
> few complaints about code style for you too. Other than that, I
> have a few comments for you below:
> 
> On 31/08/2022 05:10, Chen Guokai wrote:

> [PATCH] arch/riscv: kprobes: implement optprobes

One more nitpick thing, could you make this either "riscv"
or "RISC-V" not "arch/riscv"?

Thanks :)