Re: [PATCH v5 2/2] dts: arm: at91: Add SAMA5D3-EDS board

From: Krzysztof Kozlowski
Date: Wed Aug 31 2022 - 02:06:31 EST


On 30/08/2022 23:16, Jerry.Ray@xxxxxxxxxxxxx wrote:
>>
>>> +
>>> + chosen {
>>> + stdout-path = "serial0:115200n8";
>>> + };
>>> +
>>> + clocks {
>>> + slow_xtal {
>>
>> No underscores in node names. Generic node names, so at least add some generic prefix or suffix, e.g.: "slow-xtal-clock"
>>
>
> I'm not at liberty to change these names. Pre-existing drivers are counting on them.
> The hardware leverages the SAMA5D3-xplained board.
> I'm leveraging the at91-sama5d3_xplained.dts.
> The board will not boot up if I modify the names.

For custom names you have clock-output-names... But anyway it seems you
override existing nodes, so this should be override by label, not by
entire path.

Best regards,
Krzysztof