RE: [PATCH 3/4] bindings: firmware: Update binding doc for the zynqmp afi config node

[Manne, Nava kishore]

Hi Krzysztof,

	Please find my response inline. 

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Wednesday, August 24, 2022 6:28 PM
> To: Manne, Nava kishore <nava.kishore.manne@xxxxxxx>; git (AMD-Xilinx)
> <git@xxxxxxx>; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx;
> michal.simek@xxxxxxxxxx; mdf@xxxxxxxxxx; hao.wu@xxxxxxxxx;
> yilun.xu@xxxxxxxxx; trix@xxxxxxxxxx; p.zabel@xxxxxxxxxxxxxx;
> gregkh@xxxxxxxxxxxxxxxxxxx; ronak.jain@xxxxxxxxxx; rajan.vaja@xxxxxxxxxx;
> abhyuday.godhasara@xxxxxxxxxx; piyush.mehta@xxxxxxxxxx;
> lakshmi.sai.krishna.potthuri@xxxxxxxxxx; harsha.harsha@xxxxxxxxxx;
> linus.walleij@xxxxxxxxxx; nava.manne@xxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-fpga@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 3/4] bindings: firmware: Update binding doc for the
> zynqmp afi config node
> 
> Use subject prefixes matching the subsystem (git log --oneline -- ...).
> 
> "bindings" is no correct.

Will fix in v2.

> 
> On 24/08/2022 06:55, Nava kishore Manne wrote:
> > Updates binding document for the zynqmp afi config node to handle the
> > PS_PL Bus-width and resets.
> 
> Use imperative language:
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/sub
> mitting-patches.rst#L95

Will fix in v2.

> >
> > Signed-off-by: Nava kishore Manne <nava.kishore.manne@xxxxxxx>
> > ---
> >  .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml     | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmwa
> > re.yaml
> > b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmwa
> > re.yaml index f14f7b454f07..9504665cad95 100644
> > ---
> > a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-
> firmwa
> > re.yaml
> > +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-fi
> > +++ rmware.yaml
> > @@ -59,6 +59,13 @@ properties:
> >        controller.
> >      type: object
> >
> > +  zynqmp-fpga:
> 
> Just: fpga
> 
 
Will fix in v2.

Regards,
Navakishore.