Re: [RFC PATCH liburing v1 1/4] syscall: Add io_uring syscall functions

From: Caleb Sander
Date: Mon Aug 29 2022 - 15:53:34 EST


On Sun, Aug 28, 2022 at 8:07 PM Ammar Faizi <ammarfaizi2@xxxxxxxxxxx> wrote:
>
> --- a/src/include/liburing.h
> +++ b/src/include/liburing.h
> @@ -202,6 +202,14 @@ int io_uring_register_file_alloc_range(struct io_uring *ring,
> int io_uring_register_notifications(struct io_uring *ring, unsigned nr,
> struct io_uring_notification_slot *slots);
> int io_uring_unregister_notifications(struct io_uring *ring);
> +int io_uring_enter(unsigned int fd, unsigned int to_submit,
> + unsigned int min_complete, unsigned int flags,
> + sigset_t *sig);
> +int io_uring_enter2(int fd, unsigned to_submit, unsigned min_complete,
> + unsigned flags, sigset_t *sig, int sz);

Also, from the io_uring_enter() man page, it appears that "void *"
would be a more appropriate type for the pointer argument in
io_uring_enter2(). And "size_t" for sz.

--Caleb