Re: [PATCH] docs/core-api: expand Fedora instructions for GCC plugins

From: Kees Cook
Date: Mon Aug 29 2022 - 15:26:10 EST


On Sat, Aug 27, 2022 at 02:38:36PM -0500, Robert Elliott wrote:
> In Fedora 36, cross-compiling an allmodconfig configuration
> for other architectures on x86 fails with this problem:
>
> In file included from ../scripts/gcc-plugins/gcc-common.h:95,
> from ../scripts/gcc-plugins/latent_entropy_plugin.c:78:
> /usr/lib/gcc/aarch64-linux-gnu/12/plugin/include/builtins.h:23:10: fatal
> error: mpc.h: No such file or directory
> 23 | #include <mpc.h>
> | ^~~~~~~
> compilation terminated.
>
> In that distro, that header file is available in the separate
> libmpc-devel package.
>
> Although future versions of Fedora might correctly mark
> that dependency, mention this additional package.
>
> To help detect such problems ahead of time, describe the
> gcc -print-file-name=plugin
> command that is used by scripts/gcc-plugins/Kconfig to detect
> plugins [1].
>
> [1] https://lore.kernel.org/lkml/CAHk-=wjjiYjCp61gdAMpDOsUBU-A2hFFKJoVx5VAC7yV4K6WYg@xxxxxxxxxxxxxx/
>
> Fixes: 43e96ef8b70c50f ("docs/core-api: Add Fedora instructions for GCC plugins");
> Signed-off-by: Robert Elliott <elliott@xxxxxxx>

Thanks!

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

Jon, do you want to take this since it's entirely in the .rst file?

--
Kees Cook