Re: [PATCH v5] regulator: core: Resolve supply name earlier to prevent double-init

From: Christian Kohlschütter
Date: Mon Aug 29 2022 - 13:01:50 EST


> On 29. Aug 2022, at 17:43, Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Thu, Aug 25, 2022 at 09:28:42PM +0000, Christian Kohlschütter wrote:
>> Previously, an unresolved regulator supply reference upon calling
>> regulator_register on an always-on or boot-on regulator caused
>> set_machine_constraints to be called twice.
>
> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code. Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.
>
> Please don't send new patches in reply to old patches or serieses, this
> makes it harder for both people and tools to understand what is going
> on - it can bury things in mailboxes and make it difficult to keep track
> of what current patches are, both for the new patches and the old ones.

My apologies, I wasn't aware that's not the preferred way forward.

Following up with "regulator: core: Fix regulator supply registration with sysfs", see
https://lore.kernel.org/all/20220829165543.24856-1-christian@xxxxxxxxxxxxxxxx/