Re: [PATCH] hwmon: (nct6775) Add Asus PRIME Z390-A to WMI monitoring list

[Guenter Roeck]

On 8/29/22 09:25, Guenter Roeck wrote:
> On 8/28/22 07:43, Matti Kurkela wrote:
> > Asus PRIME Z390-A (and presumably other Asus Z390 motherboard versions) also requires the nct6775 chip to be accessed by the WMI method. Add it to the asus_wmi_boards list.
> >
> > Tested-by: Matti Kurkela <Matti.Kurkela@xxxxxx>
> > Signed-off-by: Matti Kurkela <Matti.Kurkela@xxxxxx>
>
> This is your patch. You should have tested it; that is implied in Signed-off-by:.
> Tested-by: is not appropriate.

Also, your patch didn't make it to patchwork, presumably due to a formatting
problem. I would suggest to check your formatting and make sure that it is
set to plain with no formatting options. I suspect that patchwork doesn't
like

Content-Type: text/plain; charset=UTF-8; format=flowed

Thanks,
Guenter

> > ---
> > Should apply to any kernel version that includes the commit c3963bc0a0cf9ecb205a9d4976eb92b6df2fa3fd
> > (hwmon: (nct6775) Split core and platform driver).
>
> This is irrelevant; it is a functional change and will be applied
> to linux-next.
> > --- linux-5.19.4/drivers/hwmon/nct6775-platform.c.orig  2022-08-25 12:45:54.000000000 +0300
> > +++ linux-5.19.4/drivers/hwmon/nct6775-platform.c       2022-08-28 16:28:09.531738685 +0300
> > @@ -1054,6 +1054,7 @@ static const char * const asus_wmi_board
> >          "PRIME H410M-R",
> >          "PRIME X570-P",
> >          "PRIME X570-PRO",
> > +       "PRIME Z390-A",
>
> checkpatch says:
>
> WARNING: please, no spaces at the start of a line
> #77: FILE: drivers/hwmon/nct6775-platform.c:1057:
> +       "PRIME Z390-A",$
>
>
> Please fix.
>
> Thanks,
> Guenter
>
> >          "ROG CROSSHAIR VIII DARK HERO",
> >          "ROG CROSSHAIR VIII FORMULA",
> >          "ROG CROSSHAIR VIII HERO",