Re: [PATCH v2 1/2] watchdog/hpwdt: Include nmi.h only if CONFIG_HPWDT_NMI_DECODING

[Guenter Roeck]

On 8/20/22 13:28, Jerry Hoemann wrote:
> Fixes: d48b0e173715 ("x86, nmi, drivers: Fix nmi splitup build bug")
>
> Arm64 does not support NMI and has no <asm/nmi.h>.
>
> Include <asm/nmi.h> only if CONFIG_HPWDT_NMI_DECODING is defined to
> avoid build failure on non-existent header file on Arm64.
>
> Signed-off-by: Jerry Hoemann <jerry.hoemann@xxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>   drivers/watchdog/hpwdt.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index a5006a58e0db..f79f932bca14 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -20,7 +20,9 @@
>   #include <linux/pci_ids.h>
>   #include <linux/types.h>
>   #include <linux/watchdog.h>
> +#ifdef CONFIG_HPWDT_NMI_DECODING
>   #include <asm/nmi.h>
> +#endif
>   #include <linux/crash_dump.h>
>   
>   #define HPWDT_VERSION			"2.0.4"