Re: [PATCH] LoongArch: Fix warning: #warning syscall fstat not implemented

[Tiezhu Yang]

On 8/29/22 19:36, Arnd Bergmann wrote:
> On Mon, Aug 29, 2022, at 11:55 AM, Tiezhu Yang wrote:
>
> >    CALL    scripts/checksyscalls.sh
> > <stdin>:569:2: warning: #warning syscall fstat not implemented [-Wcpp]
>
> > @@ -1,4 +1,5 @@
> > /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> > +#define __ARCH_WANT_NEW_STAT
> > #define __ARCH_WANT_SYS_CLONE
> > #define __ARCH_WANT_SYS_CLONE3
>
> The correct fix is to change scripts/checksyscalls.sh,
> making it always define __IGNORE_fstat

Hi Arnd,

Thank you very much.

I read the commit message in the commit 82b355d161c9 ("y2038: Remove
newstat family from default syscall set"), I am not quite sure whether
we should check __ARCH_WANT_NEW_STAT first, like this:

  #ifndef __ARCH_WANT_NEW_STAT
  #define __IGNORE_fstat
  #endif

Thanks,
Tiezhu