Re: [PATCH 6/6] soc: mediatek: mtk-svs: Use bitfield access macros where possible

From: Matthias Brugger
Date: Mon Aug 29 2022 - 07:05:39 EST


Hi Angelo,

On 29/08/2022 11:33, AngeloGioacchino Del Regno wrote:
Il 25/08/22 15:29, Matthias Brugger ha scritto:


On 26/07/2022 16:16, AngeloGioacchino Del Regno wrote:
In order to enhance readability and safety during registers setup
and value retrieval, redefine a few register related macros and
convert all open-coded instances of bitfield setting/retrieval
to use the FIELD_PREP() and FIELD_GET() macros.
While at it, some macros were renamed to further enhance readability.

This commit brings no functional changes.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Does not apply, would you mind to resend together with 1/6? Thanks!


Hey Matthias,

thanks for picking the ones that applied cleanly in the meanwhile.

I'll rebase this and 1/6 as soon as I can!


Nicolas did it already and both of them should be part of Linux next. Let me know if there is anything missing.

Regards,
Matthias