Re: [PATCH v4,1/2] soc: mediatek: Add mmsys func to adapt to dpi output for MT8186

[AngeloGioacchino Del Regno]

Il 29/08/22 05:21, xinlei.lee@xxxxxxxxxxxx ha scritto:
> From: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx>
>
> Add mmsys func to manipulate dpi output format config for MT8186.
>
> Co-developed-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx>
> Signed-off-by: Jitao Shi <jitao.shi@xxxxxxxxxxxx>
> Signed-off-by: Xinlei Lee <xinlei.lee@xxxxxxxxxxxx>
> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> ---
>   drivers/soc/mediatek/mt8186-mmsys.h    | 1 +
>   drivers/soc/mediatek/mtk-mmsys.c       | 8 ++++++++
>   include/linux/soc/mediatek/mtk-mmsys.h | 3 +++
>   3 files changed, 12 insertions(+)
>
> diff --git a/drivers/soc/mediatek/mt8186-mmsys.h b/drivers/soc/mediatek/mt8186-mmsys.h
> index eb1ad9c37a9c..6eca3445bea3 100644
> --- a/drivers/soc/mediatek/mt8186-mmsys.h
> +++ b/drivers/soc/mediatek/mt8186-mmsys.h
> @@ -3,6 +3,7 @@
>   #ifndef __SOC_MEDIATEK_MT8186_MMSYS_H
>   #define __SOC_MEDIATEK_MT8186_MMSYS_H
>   
> +#define MT8186_DPI_OUTPUT_FORMAT		0x400

For readability, can we please rename this definition to

MT8186_MMSYS_DPI_OUTPUT_FORMAT

Thanks,
Angelo