Re: [PATCH -next] gpio: mockup: remove gpio debugfs when remove device

From: weiyongjun (A)
Date: Sun Aug 28 2022 - 21:15:46 EST


Hi Bart,

On 2022/8/28 22:00, Bartosz Golaszewski wrote:
On Mon, Aug 22, 2022 at 3:27 PM weiyongjun (A) <weiyongjun1@xxxxxxxxxx> wrote:

Hi Bart,

On 2022/8/19 20:49, Bartosz Golaszewski wrote:
On Tue, Aug 16, 2022 at 4:34 PM Wei Yongjun <weiyongjun1@xxxxxxxxxx> wrote:

GPIO mockup debugfs is created in gpio_mockup_probe() but
forgot to remove when remove device. This patch add a devm
managed callback for removing them.


The tag -next is for patches that address issues that are in next but
not yet in master.




This isn't very relevant as the module needs to be unloaded anyway in
order to reconfigure the simulated device but I'll apply it as it's
technically correct. Did you see we have a new one - gpio-sim - that
uses configfs?

Bart



I am using gpio-mockup as a interrupt-controller with the change[1],
it works will with overfs dts[2], and can success mockup device and
trigger the irq. But when switch to gpio-sim, device can not be created
by dts[3]. Not sure what's wrong with it. Any suggestion?


I see you submitted a patch series for gpio-sim - does it fix this issue?


Yes, after that patch series, gpio-sim works well in my use case.

Thanks,
Wei Yongjun