Re: [PATCH 1/4] ACPI: s2idle: Add a new ->enter() callback for platform_s2idle_ops

From: kernel test robot
Date: Sun Aug 28 2022 - 20:39:52 EST


Hi Mario,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on linus/master v6.0-rc2 next-20220826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/Add-some-extra-debugging-mechanisms-for-s0i3/20220829-062334
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20220829/202208290836.C3cKDij9-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/af6400b51370a2bc04906697aeec5a938e6ee446
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Mario-Limonciello/Add-some-extra-debugging-mechanisms-for-s0i3/20220829-062334
git checkout af6400b51370a2bc04906697aeec5a938e6ee446
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/acpi/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/acpi/x86/s2idle.c:489:6: warning: no previous prototype for 'acpi_s2idle_enter' [-Wmissing-prototypes]
489 | void acpi_s2idle_enter(void)
| ^~~~~~~~~~~~~~~~~


vim +/acpi_s2idle_enter +489 drivers/acpi/x86/s2idle.c

488
> 489 void acpi_s2idle_enter(void)
490 {
491 struct acpi_s2idle_dev_ops *handler;
492
493 if (!lps0_device_handle || sleep_no_lps0)
494 return;
495
496 list_for_each_entry(handler, &lps0_s2idle_devops_head, list_node) {
497 if (handler->enter)
498 handler->enter();
499 }
500 }
501

--
0-DAY CI Kernel Test Service
https://01.org/lkp