Re: [PATCH v2 2/2] scsi: sd: Rework asynchronous resume support #forregzbot

From: Thorsten Leemhuis
Date: Sun Aug 28 2022 - 07:53:31 EST


TWIMC: this mail is primarily send for documentation purposes and for
regzbot, my Linux kernel regression tracking bot. These mails usually
contain '#forregzbot' in the subject, to make them easy to spot and filter.

On 17.08.22 21:07, Vlastimil Babka wrote:
> Hi, I have a T460 hanging on resume from suspend to ram in 6.0-rc1 that
> I bisected to this commit.
>
>> Unfortunately the above does not learn us anything new. The code
>> modified by commit 88f1669019bd ("scsi: sd: Rework asynchronous resume
>> support") is only called if sdev->manage_start_stop != 1. Only the SATA
>> code, the Firewire code and the manage_start_stop sysfs attribute store
>> method set that member variable:
> [...]
> #regzbot introduced: 88f1669019bd62b3
> #regzbot monitor: https://lore.kernel.org/all/20220816172638.538734-1-bvanassche@xxxxxxx/

#regzbot fixed-by: 785538bfdd682c8e962341d585f9b88262a0475

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.