Re: [PATCH ghak138 v2 1/4] audit: audit_context pid unused, context enum comment fix

From: Paul Moore
Date: Fri Aug 26 2022 - 17:16:30 EST


On Thu, Aug 25, 2022 at 3:33 PM Richard Guy Briggs <rgb@xxxxxxxxxx> wrote:
>
> The pid member of struct audit_context is never used. Remove it.
>
> The audit_reset_context() comment about unconditionally resetting
> "ctx->state" should read "ctx->context".
>
> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
> ---
> kernel/audit.h | 2 +-
> kernel/auditsc.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)

For future reference, this probably should have been split into two
patches too as there is no connection between the two changes.
However, it's trivial enough I'm just going to merge it now.

> diff --git a/kernel/audit.h b/kernel/audit.h
> index 58b66543b4d5..d6eb7b59c791 100644
> --- a/kernel/audit.h
> +++ b/kernel/audit.h
> @@ -133,7 +133,7 @@ struct audit_context {
> struct sockaddr_storage *sockaddr;
> size_t sockaddr_len;
> /* Save things to print about task_struct */
> - pid_t pid, ppid;
> + pid_t ppid;
> kuid_t uid, euid, suid, fsuid;
> kgid_t gid, egid, sgid, fsgid;
> unsigned long personality;
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 9226746dcf0a..21e50e6d0fc0 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -965,7 +965,7 @@ static void audit_reset_context(struct audit_context *ctx)
> if (!ctx)
> return;
>
> - /* if ctx is non-null, reset the "ctx->state" regardless */
> + /* if ctx is non-null, reset the "ctx->context" regardless */
> ctx->context = AUDIT_CTX_UNUSED;
> if (ctx->dummy)
> return;
> @@ -1002,7 +1002,7 @@ static void audit_reset_context(struct audit_context *ctx)
> kfree(ctx->sockaddr);
> ctx->sockaddr = NULL;
> ctx->sockaddr_len = 0;
> - ctx->pid = ctx->ppid = 0;
> + ctx->ppid = 0;
> ctx->uid = ctx->euid = ctx->suid = ctx->fsuid = KUIDT_INIT(0);
> ctx->gid = ctx->egid = ctx->sgid = ctx->fsgid = KGIDT_INIT(0);
> ctx->personality = 0;
> --
> 2.27.0

--
paul-moore.com