Re: [PATCH v2] tg3: Disable tg3 device on system reboot to avoid triggering AER

[Michael Chan]

On Thu, Aug 25, 2022 at 5:25 PM Kai-Heng Feng
<kai.heng.feng@xxxxxxxxxxxxx> wrote:

> The MSI is probably raised by incoming packets, so power down the device
> and disable bus mastering to stop the traffic, as user confirmed this
> approach works.
>
> In addition to that, be extra safe and cancel reset task if it's running.
>
> Cc: Josef Bacik <josef@xxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/all/b8db79e6857c41dab4ef08bdf826ea7c47e3bafc.1615947283.git.josef@xxxxxxxxxxxxxx/
> BugLink: https://bugs.launchpad.net/bugs/1917471
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
> ---
> v2:
>  - Move tg3_reset_task_cancel() outside of rtnl_lock() to prevent
>    deadlock.

Looks ok to me.  Thanks.

Reviewed-by: Michael Chan <michael.chan@xxxxxxxxxxxx>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature