RE: [PATCH v1 0/2] Fix the wrong order of phy callbacks

From: Hongxing Zhu
Date: Fri Aug 26 2022 - 02:57:09 EST


> -----Original Message-----
> From: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> Sent: 2022年8月26日 14:26
> To: Hongxing Zhu <hongxing.zhu@xxxxxxx>
> Cc: l.stach@xxxxxxxxxxxxxx; bhelgaas@xxxxxxxxxx;
> lorenzo.pieralisi@xxxxxxx; vkoul@xxxxxxxxxx; Marcel Ziswiler
> <marcel.ziswiler@xxxxxxxxxxx>; kishon@xxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Hongxing Zhu <hongxing.zhu@xxxxxxx>;
> linux-phy@xxxxxxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> kernel@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Subject: Re: [PATCH v1 0/2] Fix the wrong order of phy callbacks
>
> Hello Richard,
>
> Am Montag, 22. August 2022, 15:10:54 CEST schrieb Richard Zhu:
> > Refer [1], phy_init() must be called before phy_power_on().
> > This series used to fix the wrong order of the phy_init() and
> > phy_power_on(), introduced by commit 1aa97b002258 ("phy: freescale:
> pcie:
> > Initialize the imx8 pcie standalone phy driver") Tested on i.MX8MM EVK
> > board when one NVME device is used.
> >
> > [1]https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fg
> >
> it.kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ftorvalds%2Flinux.gi
> >
> t%2Ftree%2Fd&amp;data=05%7C01%7Chongxing.zhu%40nxp.com%7C56c370
> 2db1e74
> >
> 67682ea08da872bde2f%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0
> %7C63797
> >
> 0919720713123%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC
> JQIjoiV2lu
> >
> MzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3jj
> vnOExs
> > uES8A%2F2kTxlYTuTglNSK3TLY2GAR8TmMiQ%3D&amp;reserved=0
> > rivers/phy/phy-core.c?id=v5.19-rc1#n233
> >
> > [PATCH v1 1/2] PCI: imx6: Fix the wrong order of phy_init() and [PATCH
> > v1 2/2] phy: freescale: imx8m-pcie: Fix the wrong order of
>
> Together with your imx8mp patch series on TQMa8MPxl + MBa8MPxL:
> Tested-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
>
Hi Alexander:
It's great. Thanks for your kindly help.

Best Regards
Richard Zhu
> Thanks again!
> Alexander
>
>