Re: [PATCH linux-next v2] drm/mediatek: Remove the unneeded result

From: Matthias Brugger
Date: Thu Aug 25 2022 - 09:09:10 EST




On 25/08/2022 09:23, cgel.zte@xxxxxxxxx wrote:
From: ye xingchen <ye.xingchen@xxxxxxxxxx>

Return the value drm_mode_config_helper_suspend() directly instead of
storing it in another redundant variable.

Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx>

I thought I already did this in v1, anyway here we go again:

Reviewed-by: Matthias Brugger <matthias.bgg@xxxxxxxxx>

---
v1 -> v2
Add all the mailinglists that get_maintainers.pl give.
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index 5f02f8d0e4fc..91f58db5915f 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -833,11 +833,8 @@ static int mtk_drm_sys_prepare(struct device *dev)
{
struct mtk_drm_private *private = dev_get_drvdata(dev);
struct drm_device *drm = private->drm;
- int ret;
-
- ret = drm_mode_config_helper_suspend(drm);
- return ret;
+ return drm_mode_config_helper_suspend(drm);
}
static void mtk_drm_sys_complete(struct device *dev)