Re: [PATCH -next 2/2] crypto: crc32c - add missing Kconfig option select

From: Herbert Xu
Date: Thu Aug 25 2022 - 04:51:02 EST


On Thu, Aug 25, 2022 at 04:41:38PM +0800, Gaosheng Cui wrote:
> The CRYPTO_CRC32C is using functions provided by CRYPTO_MANAGER,
> otherwise the following error will occur:
>
> EXT4-fs (mmcblk0): Cannot load crc32c driver.
>
> So select CRYPTO_MANAGER when enable CRYPTO_CRC32C.
>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@xxxxxxxxxx>
> ---
> crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index b1ccf873779d..7f124604323b 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -641,6 +641,7 @@ config CRYPTO_CRC32C
> tristate "CRC32c CRC algorithm"
> select CRYPTO_HASH
> select CRC32
> + select CRYPTO_MANAGER
> help
> Castagnoli, et al Cyclic Redundancy-Check Algorithm. Used
> by iSCSI for header and data digests and by others.

Why exactly does it need CRYPTO_MANAGER?

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt