Re: [PATCH 1/1] HID: steam: Prevent NULL pointer dereference in steam_{recv,send}_report

From: Jiri Kosina
Date: Thu Aug 25 2022 - 04:22:46 EST


On Fri, 8 Jul 2022, Lee Jones wrote:

> It is possible for a malicious device to forgo submitting a Feature
> Report. The HID Steam driver presently makes no prevision for this
> and de-references the 'struct hid_report' pointer obtained from the
> HID devices without first checking its validity. Let's change that.
>
> Cc: Jiri Kosina <jikos@xxxxxxxxxx>
> Cc: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> Cc: linux-input@xxxxxxxxxxxxxxx
> Fixes: c164d6abf3841 ("HID: add driver for Valve Steam Controller")
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Sorry for the delay, I had some time off and things got stalled. Applied
now, thank you.

--
Jiri Kosina
SUSE Labs