Re: [PATCH] cxl: Replace HDM decoder granularity magic numbers

From: Adam Manzanares
Date: Thu Aug 25 2022 - 01:34:47 EST


On Wed, Aug 24, 2022 at 09:17:44AM -0700, Dan Williams wrote:
> Davidlohr Bueso wrote:
> > On Wed, 24 Aug 2022, Jonathan Cameron wrote:
> >
> > >On Mon, 22 Aug 2022 10:17:03 -0700
> > >Davidlohr Bueso <dave@xxxxxxxxxxxx> wrote:
> >
> > >> Actually the whole drivers/cxl/* could use updating the comments for 3.0.
> > >
> > >Interesting point. What do we want to do on this? Most similar
> > >cases I've been involved on rely on referring to 'oldest' compatible spec.
> > >(this is true for ACPI stuff for example).
> >
> > I find it incredibly annoying to reference table or section numbers from old
> > specs mention in the code. Unless dealing with specific version things, why
> > use old specs at all?
> >
> > The main drawback to this is obviously the constant need to update everything,
> > so...
>
> I think a happy medium is all new references being 3.0 and touching any
> old references and refresh them up to 3.0.

I'll shoot for the happy medium in a v2.

>
> That said if someone wants to do the work to refresh all of them, and
> someone else wants to review those updates I would take the patch.