Re: [PATCH net-next v4 2/3] net: skb: use auto-generation to convert skb drop reason to string

[Menglong Dong]

On Thu, Aug 25, 2022 at 9:10 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Wed, 24 Aug 2022 17:45:15 -0700 Eric Dumazet wrote:
> > After this patch, I no longer have strings added after the reason: tag
>
> Hm, using a kernel address (drop_reasons) as an argument to TP_printk()
> definitely does not look right, but how to tickle whatever magic
> __print_symbolic was providing I do not know :S
>
>         TP_printk("skbaddr=%p protocol=%u location=%p reason: %s",
>                   __entry->skbaddr, __entry->protocol, __entry->location,
> -                 __print_symbolic(__entry->reason,
> -                                  TRACE_SKB_DROP_REASON))
> +                 drop_reasons[__entry->reason])

it seems that TP_printk is not as simple as I thought.......

Sorry for the problem I brought, I'm looking for a solution.

Thanks!
Menglong Dong