Re: [PATCH v5 07/12] x86/cpu/keylocker: Load an internal wrapping key at boot-time

From: Chang S. Bae
Date: Wed Aug 24 2022 - 21:06:40 EST


On 8/24/2022 3:52 PM, Evan Green wrote:

Whatever we ended up landing in the ChromeOS tree (which I think was
v4 of this series) actively hit this bug in hibernation, which is how
I found it. I couldn't get a full backtrace because the backtracing
code tripped over itself as well for some reason. If the next patch in
this series is different from what we landed in ChromeOS, then maybe
your description is correct, but I haven't dug in to understand the
delta.

So the change from v4 is simply dropping CBC mode. Marvin who reported another issue told me that he pushed the fix to some Chrome repository. But I don't know that's the same repo that you mentioned. Are you able to locate that tree if possible?

Also, it would be nice to have more detail about that hibernation bug.

Thanks,
Chang