Re: drivers/gpu/host1x/context.c:65:23: error: too many arguments to function 'of_dma_configure_id'

From: Thierry Reding
Date: Wed Aug 24 2022 - 11:34:59 EST


On Wed, Aug 24, 2022 at 04:59:56AM +0800, kernel test robot wrote:
> Hi Mikko,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 072e51356cd5a4a1c12c1020bc054c99b98333df
> commit: 8aa5bcb61612060429223d1fbb7a1c30a579fc1f gpu: host1x: Add context device management code
> date: 7 weeks ago
> config: arm-randconfig-r012-20220823 (https://download.01.org/0day-ci/archive/20220824/202208240444.uTBVAbiI-lkp@xxxxxxxxx/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8aa5bcb61612060429223d1fbb7a1c30a579fc1f
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout 8aa5bcb61612060429223d1fbb7a1c30a579fc1f
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/gpu/host1x/
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> All errors (new ones prefixed by >>):
>
> drivers/gpu/host1x/context.c: In function 'host1x_memory_context_list_init':
> >> drivers/gpu/host1x/context.c:65:23: error: too many arguments to function 'of_dma_configure_id'
> 65 | err = of_dma_configure_id(&ctx->dev, node, true, &i);
> | ^~~~~~~~~~~~~~~~~~~
> In file included from include/linux/of_platform.h:12,
> from drivers/gpu/host1x/context.c:9:
> include/linux/of_device.h:103:19: note: declared here
> 103 | static inline int of_dma_configure_id(struct device *dev,
> | ^~~~~~~~~~~~~~~~~~~

Looks like this was caused by a mismatch in the signature of this
function for !OF builds. I've sent out a patch, so hopefully this will
get fixed in linux-next (and mainline) soon.

Thanks,
Thierry

Attachment: signature.asc
Description: PGP signature