Re: [PATCH v2 2/3] lib/find_bit: create find_first_zero_bit_le()

[Andy Shevchenko]

On Wed, Aug 24, 2022 at 12:22 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Wed, Aug 24, 2022 at 5:17 AM Yury Norov <yury.norov@xxxxxxxxx> wrote:

...

> > +#define word_op swab
> > +#include "find_bit.h"
>
> Looking at this, I would rather always require to define __ffs_word_op
> (or whatever name) in the user and replace #ifndef in the find_bit.h
> with
> #error "The __ffs_word_op must be defined before including find_bit.h!"

The rationale is that the missed definition may give wrong results
while being compiled with no errors. With the above, the developer
must think about what they are doing.

-- 
With Best Regards,
Andy Shevchenko