Re: [PATCH -next 1/2] rv/monitors: add 'static' qualifier for local symbols

From: Daniel Bristot de Oliveira
Date: Wed Aug 24 2022 - 02:33:39 EST


On 8/24/22 05:43, Zeng Heng wrote:
> The sparse tool complains as follows:
>
> kernel/trace/rv/monitors/wwnr/wwnr.c:18:19:
> warning: symbol 'rv_wwnr' was not declared. Should it be static?
>
> The `rv_wwnr` symbol is not dereferenced by other extern files,
> so add static qualifier for it.
>
> So does wip module.
>
> Fixes: ccc319dcb450 ("rv/monitor: Add the wwnr monitor")
> Fixes: 8812d21219b9 ("rv/monitor: Add the wip monitor skeleton created by dot2k")
> Signed-off-by: Zeng Heng <zengheng4@xxxxxxxxxx>

Acked-by: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>

Thanks!
-- Daniel