Re: [for-linus][PATCH 01/10] tracing: Suppress sparse warnings triggered by is_signed_type()

From: Bart Van Assche
Date: Tue Aug 23 2022 - 23:47:30 EST


On 8/23/22 19:11, Linus Torvalds wrote:
Side note: I think you could move this into '<linux/compiler.h>' and that would

(a) make some conceptual sense (unlike "overflow.h" and "trace_events.h")

and

(b) mean it gets included automatically in both files.

overflow.h already explicitly includes compiler.h, and trace_events.h
gets it from

linux/ring_buffer.h -> linux/mm.h -> linux/bug.h -> asm/bug.h ->
linux/compiler.h

(it goes other wats too, but those ones are through arch-specific asm
headers, so the above is the first non-arch-specific unconditional
chain I found.

OK, I will look into moving the definition of is_signed_type() into compiler.h.

Thanks,

Bart.