Re: [PATCH v4.4] net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy

From: Andrew Lunn
Date: Tue Aug 23 2022 - 15:50:58 EST


> > The user could of changed the pause settings, which are going to be
> > ignored here. Also, you should not assume the MAC can actually do
> > asymmetric pause, not all can. phydev->advertising will be set to only
> > include what the MAC can actually do.

> Interesting. Just to confirm - regardless of the two-sided design..
> -edness.. IIUC my question has merit and we need v5?

Yes, phydev->advertising should be take into account.

Andrew