Re: [PATCH 4/4] input: joystick: Fix buffer data parsing

From: Jonathan Cameron
Date: Mon Aug 22 2022 - 15:36:05 EST


> >> case 2:
> >> - data_u16 = (const u16 *)data + idx;
> >> -
> >> /*
> >> * Data is aligned to the sample size by IIO core.
> >> * Call `get_unaligned_xe16` to hide type casting.
> >> */
> >> if (endianness == IIO_BE)
> >> - val = get_unaligned_be16(data_u16);
> >> + val = get_unaligned_be16(chan_data);
> >
> > I obviously missed this previously but these are aligned so we don't
> > need the
> > unaligned form.
>
> Yes, the comment above says that it's used to hide type casting.
oops :)

Thanks for pointing out my lack of observation!

Jonathan