Re: [PATCH] media: uvcvideo: Fix InterfaceProtocol for Quanta camera

[Laurent Pinchart]

Hi Ricardo,

Thank you for the patch.

On Mon, Aug 08, 2022 at 03:41:06PM +0200, Ricardo Ribalda wrote:
> The device is using a different InterfaceProtocol than the one set in
> the original quirk.
> 
> Fixes: 95f03d973478 ("media: uvcvideo: Limit power line control for Quanta cameras")
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> ---
> 
> This was fixed on the last version of the patchset. Unfortunately I did
> checked that it was the version merged :(.

Oops :-(

> It is too late to land it in this version?

I think it can be considered as a v6.0 fix, yes.

>  drivers/media/usb/uvc/uvc_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 9c05776f11d1..6556158a8888 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2740,7 +2740,7 @@ static const struct usb_device_id uvc_ids[] = {
>  	  .idProduct		= 0x4034,
>  	  .bInterfaceClass	= USB_CLASS_VIDEO,
>  	  .bInterfaceSubClass	= 1,
> -	  .bInterfaceProtocol	= 0,
> +	  .bInterfaceProtocol	= 1,

Should we use UVC_PC_PROTOCOL_15 here ?

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

>  	  .driver_info		= (kernel_ulong_t)&uvc_ctrl_power_line_limited },
>  	/* LogiLink Wireless Webcam */
>  	{ .match_flags		= USB_DEVICE_ID_MATCH_DEVICE

-- 
Regards,

Laurent Pinchart