Re: [PATCH] ftrace: makes ops_references_rec() inline

[Song Liu]

On Sun, Aug 21, 2022 at 7:31 PM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
>
> commit 53cd885bc5c3e ("ftrace: Allow IPMODIFY and DIRECT ops on the
> same function") changed ops_references_rec() inline to function,
> thus we will get below error if .config doesn't have CONFIG_MODULES.
>
>   CC      kernel/trace/ftrace.o
> ${linux}/kernel/trace/ftrace.c:3149:1: error: 'ops_references_rec' \
> defined but not used [-Werror=unused-function]
>  3149 | ops_references_rec(struct ftrace_ops *ops, struct dyn_ftrace *rec)
>       | ^~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[2]: *** [${linux}/scripts/Makefile.build:249: kernel/trace/ftrace.o] error 1
> make[1]: *** [${linux}/scripts/Makefile.build:466: kernel/trace] error 2
> make: *** [/opt/disk_cd/morimoto/linux/Makefile:1843: kernel] error 2
>
> This patch makes it to inline again, and fixes the issue.
>
> Fixes:  53cd885bc5c3e ("ftrace: Allow IPMODIFY and DIRECT ops on the same function")
> CC: Song Liu <song@xxxxxxxxxx>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

Acked-by: Song Liu <song@xxxxxxxxxx>

Thanks for the fix!