Re: [PATCH 1/4] media: dt-bindings: media: Document RZ/G2L CSI-2 block

From: Lad, Prabhakar
Date: Fri Aug 19 2022 - 07:38:26 EST


Hi Geert,

Thank you for the review.

On Thu, Aug 18, 2022 at 9:56 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Mon, Aug 1, 2022 at 11:47 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> > Document the CSI-2 block which is part of CRU found in Renesas
> > RZ/G2L SoC.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> > RFC v2 -> v1
> > * Fixed review comments pointed by Rob and Jacopo.
>
> Thanks for the update!
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> > @@ -0,0 +1,149 @@
>
> > + resets:
> > + items:
> > + - description: CRU_CMN_RSTB reset terminal
> > +
> > + reset-names:
> > + const: cmn-rstb
>
> While it doesn't hurt to always have reset-names, you may want to drop
> it, as there is only a single reset.
>
Agreed, I will drop it.

Cheers,
Prabhakar