Re: [PATCH v2] crypto: ccp: Add a quirk to firmware update

From: Herbert Xu
Date: Fri Aug 19 2022 - 07:03:19 EST


On Wed, Aug 10, 2022 at 01:49:15AM +0300, Jarkko Sakkinen wrote:
> From: Jarkko Sakkinen <jarkko@xxxxxxxxxxx>
>
> A quirk for fixing the committed TCB version, when upgrading from a
> firmware version earlier than 1.50. This is a known issue, and the
> documented workaround is to load the firmware twice.
>
> Currently, this issue requires the following workaround:
>
> sudo modprobe -r kvm_amd
> sudo modprobe -r ccp
> sudo modprobe ccp
> sudo modprobe kvm_amd
>
> Implement this workaround inside kernel by checking whether the API
> version is less than 1.50, and if so, download the firmware twice.
> This addresses the TCB version issue.
>
> Link: https://lore.kernel.org/all/de02389f-249d-f565-1136-4af3655fab2a@xxxxxxxxxxx/
> Reported-by: Harald Hoyer <harald@xxxxxxxxxxx>
> Signed-off-by: Jarkko Sakkinen <jarkko@xxxxxxxxxxx>
> ---
> v2:
> - Updated the commit message and comments.
> https://lore.kernel.org/all/0a3a790d-989f-2f76-f636-62fbd925a776@xxxxxxx/
> drivers/crypto/ccp/sev-dev.c | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt