RE: [PATCH v2 4/7] EDAC: Get chipset-specific edac drivers selected only when ghes_edac is not enabled

From: Justin He
Date: Thu Aug 18 2022 - 21:57:46 EST




> -----Original Message-----
> From: Kani, Toshi <toshi.kani@xxxxxxx>
> Sent: Friday, August 19, 2022 7:57 AM
> To: Justin He <Justin.He@xxxxxxx>; Ard Biesheuvel <ardb@xxxxxxxxxx>; Len
> Brown <lenb@xxxxxxxxxx>; James Morse <James.Morse@xxxxxxx>; Tony Luck
> <tony.luck@xxxxxxxxx>; Borislav Petkov <bp@xxxxxxxxx>; Mauro Carvalho
> Chehab <mchehab@xxxxxxxxxx>; Robert Richter <rric@xxxxxxxxxx>; Robert
> Moore <robert.moore@xxxxxxxxx>; Qiuxu Zhuo <qiuxu.zhuo@xxxxxxxxx>;
> Yazen Ghannam <yazen.ghannam@xxxxxxx>
> Cc: linux-acpi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-edac@xxxxxxxxxxxxxxx; devel@xxxxxxxxxx; Rafael J . Wysocki
> <rafael@xxxxxxxxxx>; Shuai Xue <xueshuai@xxxxxxxxxxxxxxxxx>; Jarkko
> Sakkinen <jarkko@xxxxxxxxxx>; linux-efi@xxxxxxxxxxxxxxx; nd <nd@xxxxxxx>
> Subject: RE: [PATCH v2 4/7] EDAC: Get chipset-specific edac drivers selected
> only when ghes_edac is not enabled
>
> On Wednesday, August 17, 2022 8:35 AM, Jia He wrote:
> > When ghes_edac is loaded, a regular edac driver for the CPU type /
> > platform still attempts to register itself and fails in its module_init call.
> >
> > Suggested-by: Toshi Kani <toshi.kani@xxxxxxx>
> > Suggested-by: Borislav Petkov <bp@xxxxxxxxx>
> > Signed-off-by: Jia He <justin.he@xxxxxxx>
> > ---
> > drivers/edac/amd64_edac.c | 3 +++
> > drivers/edac/pnd2_edac.c | 3 +++
> > drivers/edac/sb_edac.c | 3 +++
> > drivers/edac/skx_base.c | 3 +++
> > 4 files changed, 12 insertions(+)
>
> Can you change i10nm_base.c and igen6_edac.c as well?
>
> They are listed in your list below.
>
Okay, will do. And will also include the ARM specific edac drivers just as
Borislav mentioned.


--
Cheers,
Justin (Jia He)