Re: [PATCH v3 2/2] USB: trancevibrator: simplify tv_probe

From: Greg Kroah-Hartman
Date: Thu Aug 18 2022 - 11:07:11 EST


On Fri, Aug 12, 2022 at 02:18:02PM +0800, Dongliang Mu wrote:
> From: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
>
> The function tv_probe does not need to invoke kfree when the
> allocation fails. So let's simplify the code of tv_probe.
>
> Signed-off-by: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
> ---
> v2->v3: fix the truncated subject of PATCH 2/2.
> v1->v2: no change
>
> drivers/usb/misc/trancevibrator.c | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)

Note, I would recommend you work on basic "clean up" patches in the
drivers/staging/ directory so as to get experience on how to submit
patches properly before working in other parts of the kernel tree. That
way subsystems that don't normally take "cleanup" patches don't get
bogged down in basic patch-process issues like this one did.

thanks,

greg k-h