Re: [PATCH v1 6/6] perf build: Enable -Wthread-safety with clang

From: Namhyung Kim
Date: Thu Aug 18 2022 - 02:11:21 EST


Hi Ian,

On Tue, Aug 16, 2022 at 10:39 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> If building with clang then enable -Wthread-safety warnings.

Do you know the minimal supported version for the option?
I'm not sure we have a check for that kind of thing.

Thanks,
Namhyung


>
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
> tools/perf/Makefile.config | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index 0661a1cf9855..0ef6f572485d 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -19,6 +19,11 @@ detected_var = $(shell echo "$(1)=$($(1))" >> $(OUTPUT).config-detected)
> CFLAGS := $(EXTRA_CFLAGS) $(filter-out -Wnested-externs,$(EXTRA_WARNINGS))
> HOSTCFLAGS := $(filter-out -Wnested-externs,$(EXTRA_WARNINGS))
>
> +# Enabled Wthread-safety analysis for clang builds.
> +ifeq ($(CC_NO_CLANG), 0)
> + CFLAGS += -Wthread-safety
> +endif
> +
> include $(srctree)/tools/scripts/Makefile.arch
>
> $(call detected_var,SRCARCH)
> --
> 2.37.1.595.g718a3a8f04-goog
>