Re: [PATCH] tracing/perf: Fix double put of trace event when init fails

From: Steven Rostedt
Date: Wed Aug 17 2022 - 10:04:46 EST


On Tue, 16 Aug 2022 21:46:56 -0700
Krister Johansen <kjlx@xxxxxxxxxxxxxxxxxx> wrote:

> Thanks again, Steven. Is this one that you would consider tagging for a
> backport to stable at the appropriate time? I believe this one showed up
> in 5.15, if it's any help.

So the warning started with this commit:

1d18538e6a092 ("tracing: Have dynamic events have a ref counter")

Which switched the module_put() to the trace_event_put(). I guess the
difference is that module_put() has

ret = atomic_dec_if_positive(&module->refcnt);

Where it could be called more than once after reaching zero and not warn
about it. But the trace_event_put() will warn if you call it after it
reaches zero.

I'll add a stable tag.

-- Steve