Re: [1/6] wifi: brcmfmac: fix continuous 802.1x tx pending timeout error

From: Alvin Šipraga
Date: Wed Aug 17 2022 - 04:34:46 EST


Hi Kalle,

On Wed, Aug 10, 2022 at 05:48:01AM +0000, Kalle Valo wrote:
> Alvin Šipraga <alvin@xxxxxxx> wrote:
>
> > From: Wright Feng <wright.feng@xxxxxxxxxxx>
> >
> > The race condition in brcmf_msgbuf_txflow and brcmf_msgbuf_delete_flowring
> > makes tx_msghdr writing after brcmf_msgbuf_remove_flowring. Host
> > driver should delete flowring after txflow complete and all txstatus back,
> > or pend_8021x_cnt will never be zero and cause every connection 950
> > milliseconds(MAX_WAIT_FOR_8021X_TX) delay.
> >
> > Signed-off-by: Wright Feng <wright.feng@xxxxxxxxxxx>
> > Signed-off-by: Chi-hsien Lin <chi-hsien.lin@xxxxxxxxxxx>
> > Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> > Signed-off-by: Alvin Šipraga <alsi@xxxxxxxxxxxxxxx>
>
> 5 patches applied to wireless-next.git, thanks.
>
> 0fa24196e425 wifi: brcmfmac: fix continuous 802.1x tx pending timeout error
> 09be7546a602 wifi: brcmfmac: fix scheduling while atomic issue when deleting flowring
> aa666b68e73f wifi: brcmfmac: fix invalid address access when enabling SCAN log level
> 5606aeaad01e wifi: brcmfmac: Fix to add brcmf_clear_assoc_ies when rmmod
> 2eee3db784a0 wifi: brcmfmac: Fix to add skb free for TIM update info when tx is completed

Thanks. Do you mind elaborating on why the 6th patch:

brcmfmac: Update SSID of hidden AP while informing its bss to cfg80211 layer

was not applied?

Kind regards,
Alvin