Re: [PATCH net-next v4] net: skb: prevent the split of kfree_skb_reason() by gcc

[Menglong Dong]

On Tue, Aug 16, 2022 at 5:02 PM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Tue, Aug 16, 2022 at 5:29 AM <menglong8.dong@xxxxxxxxx> wrote:
> >
> > Reported-by: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
>
> Hmm... Why did you add me as a reporter?
>

Enn...because you pointed out my code's problem, just like what robot do.
Shouldn't I?

> > + * Optional: not supported by clang.
> > + * Optional: not supported by icc.
>
> Much better, thank you! Please add the links to GCC's docs, like in
> most attributes (some newer attributes may have been added without
> them -- I will fix that).
>
> In any case, no need to send a new version just for this for the
> moment, I would recommend waiting until others comment on whether they
> want `__optimize__` used here as the workaround.
>

Okay, I'll wait longer before the next version.

Thanks!
Menglong Dong

> Cheers,
> Miguel