Re: [PATCH v2] docs: admin-guide/mm: Improve grammar on MM concepts documentation

From: Randy Dunlap
Date: Tue Aug 16 2022 - 18:36:49 EST


Hi--

On 8/15/22 19:26, alexlzhu@xxxxxx wrote:
> From: Alexander Zhu <alexlzhu@xxxxxx>
>
> Improve grammar on MM concepts documentation.
>
> Signed-off-by: Alexander Zhu <alexlzhu@xxxxxx>
> ---
> Documentation/admin-guide/mm/concepts.rst | 138 +++++++++++-----------
> 1 file changed, 68 insertions(+), 70 deletions(-)
>
> diff --git a/Documentation/admin-guide/mm/concepts.rst b/Documentation/admin-guide/mm/concepts.rst
> index c79f1e336222..c471f80b7a38 100644
> --- a/Documentation/admin-guide/mm/concepts.rst
> +++ b/Documentation/admin-guide/mm/concepts.rst

[snip]

> -Depending on the page usage it is treated differently by the Linux
> -memory management. The pages that can be freed at any time, either
> -because they cache the data available elsewhere, for instance, on a
> -hard disk, or because they can be swapped out, again, to the hard
> +Depending on page usage it is treated differently by the Linux
> +memory management subsystem. Pages that can be freed at any time,
> +either because they cache the data available elsewhere
> +(ie on a hard disk) or because they can be swapped out to the hard

(i.e., on a hard disk)

> disk, are called `reclaimable`. The most notable categories of the
> reclaimable pages are page cache and anonymous memory.
>

[snip]

>
> Compaction
> ==========
>
> -As the system runs, tasks allocate and free the memory and it becomes
> +As the system runs, tasks will allocate and free memory. Memory thus becomes

Addition of "will" is not needed.

> fragmented. Although with virtual memory it is possible to present
> -scattered physical pages as virtually contiguous range, sometimes it is
> +scattered physical pages as a virtually contiguous range, sometimes it is
> necessary to allocate large physically contiguous memory areas. Such
> need may arise, for instance, when a device driver requires a large
> buffer for DMA, or when THP allocates a huge page. Memory `compaction`

Thanks.
--
~Randy