Re: [PATCH v2 15/26] thermal/drivers/rcar_gen3: Use the generic function to get the number of trips

From: Niklas Söderlund
Date: Tue Aug 16 2022 - 06:31:26 EST


Hello Daniel,

Thanks for your work.

On 2022-08-10 00:04:25 +0200, Daniel Lezcano wrote:
> The thermal core framework allows to get the number of thermal trips,
> use it instead of visiting the thermal core structure internals.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> ---
> drivers/thermal/rcar_gen3_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
> index 40ec63ad0a1b..6a6aaad2bcac 100644
> --- a/drivers/thermal/rcar_gen3_thermal.c
> +++ b/drivers/thermal/rcar_gen3_thermal.c
> @@ -525,7 +525,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
> if (ret)
> goto error_unregister;
>
> - ret = of_thermal_get_ntrips(tsc->zone);
> + ret = thermal_zone_get_num_trips(tsc->zone);
> if (ret < 0)
> goto error_unregister;
>
> --
> 2.34.1
>

--
Kind Regards,
Niklas Söderlund