Re: [PATCH] serial: icom: Fix some indentation

[Jiri Slaby]

On 15. 08. 22, 14:05, Christophe JAILLET wrote:
> checkpatch and smatch report some code alignment issues.
>
> So remove some unneeded leading spaces to fix the warnings.
>
> While at it remove some {} around a single statement and convert some
> spaces into a tab.

Looks good, but maintainers don't like the "While at it" part :D.

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
>   drivers/tty/serial/icom.c | 27 +++++++++++++--------------
>   1 file changed, 13 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/tty/serial/icom.c b/drivers/tty/serial/icom.c
> index 45df29947fe8..3ac81622c4fb 100644
> --- a/drivers/tty/serial/icom.c
> +++ b/drivers/tty/serial/icom.c
> @@ -1727,10 +1727,10 @@ static int icom_probe(struct pci_dev *dev,
>   
>   	retval = pci_request_regions(dev, "icom");
>   	if (retval) {
> -		 dev_err(&dev->dev, "pci_request_regions FAILED\n");
> -		 pci_disable_device(dev);
> -		 return retval;
> -	 }
> +		dev_err(&dev->dev, "pci_request_regions FAILED\n");
> +		pci_disable_device(dev);
> +		return retval;
> +	}
>   
>   	pci_set_master(dev);
>   
> @@ -1754,9 +1754,9 @@ static int icom_probe(struct pci_dev *dev,
>   
>   	retval = icom_alloc_adapter(&icom_adapter);
>   	if (retval) {
> -		 dev_err(&dev->dev, "icom_alloc_adapter FAILED\n");
> -		 retval = -EIO;
> -		 goto probe_exit0;
> +		dev_err(&dev->dev, "icom_alloc_adapter FAILED\n");
> +		retval = -EIO;
> +		goto probe_exit0;
>   	}
>   
>   	icom_adapter->base_addr_pci = pci_resource_start(dev, 0);
> @@ -1778,11 +1778,10 @@ static int icom_probe(struct pci_dev *dev,
>   		goto probe_exit1;
>   	}
>   
> -	 /* save off irq and request irq line */
> -	 retval = request_irq(dev->irq, icom_interrupt, IRQF_SHARED, ICOM_DRIVER_NAME, (void *)icom_adapter);
> -	 if (retval) {
> -		  goto probe_exit2;
> -	 }
> +	/* save off irq and request irq line */
> +	retval = request_irq(dev->irq, icom_interrupt, IRQF_SHARED, ICOM_DRIVER_NAME, (void *)icom_adapter);
> +	if (retval)
> +		goto probe_exit2;
>   
>   	retval = icom_load_ports(icom_adapter);
>   
> @@ -1798,11 +1797,11 @@ static int icom_probe(struct pci_dev *dev,
>   			icom_port->uart_port.fifosize = 16;
>   			icom_port->uart_port.ops = &icom_ops;
>   			icom_port->uart_port.line =
> -		        icom_port->port + icom_adapter->index * 4;
> +			icom_port->port + icom_adapter->index * 4;
>   			if (uart_add_one_port (&icom_uart_driver, &icom_port->uart_port)) {
>   				icom_port->status = ICOM_PORT_OFF;
>   				dev_err(&dev->dev, "Device add failed\n");
> -			 } else
> +			} else
>   				dev_info(&dev->dev, "Device added\n");
>   		}
>   	}

--
js
suse labs