Re: [PATCH] m68k: Complete variable type

From: Al Viro
Date: Tue Aug 16 2022 - 04:14:12 EST


On Tue, Aug 16, 2022 at 09:37:19AM +1000, Greg Ungerer wrote:
> On 16/8/22 05:48, Xin Gao wrote:
> > @@ -169,7 +169,7 @@ void q40_sched_init (void)
> > *
> > */
> > -struct IRQ_TABLE{ unsigned int mask; int irq ;};
> > +struct IRQ_TABLE{ unsigned int mask; int irq };
> > #if 0
> > static struct IRQ_TABLE iirqs[]={
> > {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
>
> This last change doesn't match the commit message.
> It should be a separate patch.

The last change is not a valid C. Never had been.
In C semicolon is *NOT* a separator - it's a part of declaration.

--
improve the kernel quality - git rm scripts/checkpatch.pl