Re: [PATCH 5.15 154/779] netfilter: nf_tables: add rescheduling points during loop detection walks

From: Florian Westphal
Date: Mon Aug 15 2022 - 16:18:54 EST


Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> From: Florian Westphal <fw@xxxxxxxxx>
>
> [ Upstream commit 81ea010667417ef3f218dfd99b69769fe66c2b67 ]
>
> Add explicit rescheduling points during ruleset walk.

NAK. There is a partial revert pending.

> @@ -9225,9 +9227,13 @@ static int nf_tables_check_loops(const struct nft_ctx *ctx,
> break;
> }
> }
> +
> + cond_resched();
> }
>
> list_for_each_entry(set, &ctx->table->sets, list) {
> + cond_resched();

Can't be used here, this can be called from atomic context.