Re: [PATCH] spi: lpspi: Simplify some error message

From: Alexander Stein
Date: Mon Aug 15 2022 - 07:07:19 EST


Am Freitag, 5. August 2022, 23:39:19 CEST schrieb Christophe JAILLET:
> dev_err_probe() already prints the error code in a human readable way, so
> there is no need to duplicate it as a numerical value at the end of the
> message.
>
> Fixes: 12f62a857c83 ("spi: lpspi: Silence error message upon deferred
> probe") Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> drivers/spi/spi-fsl-lpspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
> index 19b1f3d881b0..cbbe8bbef90a 100644
> --- a/drivers/spi/spi-fsl-lpspi.c
> +++ b/drivers/spi/spi-fsl-lpspi.c
> @@ -912,7 +912,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev)
>
> ret = devm_spi_register_controller(&pdev->dev, controller);
> if (ret < 0) {
> - dev_err_probe(&pdev->dev, ret, "spi_register_controller
error: %i\n",
> ret); + dev_err_probe(&pdev->dev, ret, "spi_register_controller
error\n");
> goto free_dma;
> }

Acked-By: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>