Re: upstream kernel crashes

[Andres Freund]

Hi, 

On August 15, 2022 1:28:29 AM PDT, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
>On Mon, Aug 15, 2022 at 01:15:27AM -0700, Andres Freund wrote:
>> Hi,
>> 
>> On 2022-08-15 03:51:34 -0400, Michael S. Tsirkin wrote:
>> > It is possible that GCP gets confused if ring size is smaller than the
>> > device maximum simply because no one did it in the past.
>> > 
>> > So I pushed just the revert of 762faee5a267 to the test branch.
>> > Could you give it a spin?
>> 
>> Seems to fix the issue, at least to the extent I can determine at 1am... :)
>> 
>> Greetings,
>> 
>> Andres Freund
>
>So you tested this:
>
>commit 13df5a7eaeb22561d39354b576bc98a7e2c389f9 (HEAD, kernel.org/test)
>Author: Michael S. Tsirkin <mst@xxxxxxxxxx>
>Date:   Mon Aug 15 03:44:38 2022 -0400
>
>    Revert "virtio_net: set the default max ring size by find_vqs()"
>    
>    This reverts commit 762faee5a2678559d3dc09d95f8f2c54cd0466a7.
>    
>    Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
>
>and it fixes both issues right? No crashes no networking issue?

Correct. I only did limited testing, but it's survived far longer / more reboots than anything since the commit.

Andres
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.